Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(all): better interfaces, add router event export, more tests #632

Merged
merged 17 commits into from
Apr 15, 2019

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented Mar 29, 2019

No description provided.

@bigopon
Copy link
Member Author

bigopon commented Mar 30, 2019

This is now ready for review.

@bigopon
Copy link
Member Author

bigopon commented Mar 30, 2019

For comparison, typings is based on 1.5.0 release (same for 1.6) at https://github.com/aurelia/router/blob/2a8a16622dc162c9bd24028a76420692f2a0882a/dist/aurelia-router.d.ts

@bigopon
Copy link
Member Author

bigopon commented Apr 13, 2019

The latest commits https://github.com/aurelia/router/pull/632/files/26facc5f83fd7bb48da8e5015efb943e913c21f7..7d3ee63e77d585f7964ea6706163e1cd2dff7691 will export a few critical information related to router event enum and pipeline slot name enum, along with some comments for better understanding & usage

@EisenbergEffect
Copy link
Contributor

@bigopon Is this ready?

@bigopon
Copy link
Member Author

bigopon commented Apr 15, 2019

@EisenbergEffect yes it is ready. Everything has been reverted to internak refactoring instead of aiming for a 2.0 beta. Its a big refactoring so if needed, we can do a RC release

@EisenbergEffect EisenbergEffect merged commit f57fb9b into aurelia:master Apr 15, 2019
@EisenbergEffect
Copy link
Contributor

@bigopon What is the release process for this library now? Just build and release from master? After this next release, will we be able to use the develop branch and align this process with the other updated repos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants